Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Adding Sweeper Test for Fabric Cloud Router Resource #747

Merged
merged 9 commits into from
Aug 7, 2024
Merged

test: Adding Sweeper Test for Fabric Cloud Router Resource #747

merged 9 commits into from
Aug 7, 2024

Conversation

srushti-patl
Copy link
Contributor

  • Added sweeper test for "equinix_fabric_cloud_router" resource

@srushti-patl srushti-patl requested review from a team as code owners August 1, 2024 20:21
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 12.24490% with 43 lines in your changes missing coverage. Please review.

Project coverage is 34.39%. Comparing base (f8c2ab9) to head (fecc389).
Report is 27 commits behind head on main.

Files Patch % Lines
equinix/resource_fabric_cloud_router_sweeper.go 12.24% 43 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   34.44%   34.39%   -0.05%     
==========================================
  Files         151      154       +3     
  Lines       20710    21074     +364     
==========================================
+ Hits         7133     7249     +116     
- Misses      13415    13664     +249     
+ Partials      162      161       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thogarty
thogarty requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested.

equinix/equinix_sweeper_test.go Outdated Show resolved Hide resolved
@srushti-patl srushti-patl requested a review from ctreatma August 5, 2024 19:09
@srushti-patl srushti-patl requested a review from thogarty August 5, 2024 19:09
@ctreatma
Copy link
Contributor

ctreatma commented Aug 6, 2024

The new sweeper looks to be wired up correctly and running in CI: https://github.com/equinix/terraform-provider-equinix/actions/runs/10254555205/job/28369616675?pr=747#step:7:32

thogarty
thogarty approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ctreatma ctreatma changed the title feat: Adding Sweeper Test for Fabric Cloud Router Resource test: Adding Sweeper Test for Fabric Cloud Router Resource Aug 7, 2024
ctreatma
ctreatma approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I changed the Conventional Commit tag in the PR title from feat to test since this only changes test files and is not a customer-facing feature.

@ctreatma ctreatma merged commit 0baf032 into main Aug 7, 2024
9 of 12 checks passed
@ctreatma ctreatma deleted the CXF-93686-Cloud-Router-Sweeper-Test branch August 7, 2024 21:00
@github-actions GitHub Actions
Copy link

This PR is included in version 2.3.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thogarty thogarty thogarty approved these changes

@ctreatma ctreatma ctreatma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srushti-patl @codecov-commenter @ctreatma @thogarty